Java: File constructor path sanitizer
#18504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcogs33
force-pushed
the
jcogs33/java/file-constructor-path-sanitizer
branch
from
4dc7562 to
7837ad6
Compare
jcogs33
force-pushed
the
jcogs33/java/file-constructor-path-sanitizer
branch
from
8ef7637 to
60cc16c
Compare
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
java/ql/test/library-tests/pathsanitizer/Test.java:482
- Several consecutive blocks (lines 480–610) repeat similar path validation logic. Consider extracting this shared logic into a utility method or parameterized test to simplify and reduce duplication.
File f1 = new File("safe/file.txt");
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
owen-mc
reviewed
Feb 5, 2025
owen-mc
reviewed
Feb 5, 2025
owen-mc
reviewed
Feb 5, 2025
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,10,4622,259,99,,9,,,26
+ Java Standard Library,``java.*``,10,4621,259,99,,9,,,26
- Totals,,312,26329,2635,404,16,128,33,1,409
+ Totals,,312,26328,2635,404,16,128,33,1,409
- java.io,66,1,226,,,,,,,,,22,,,,,,,,,,,,,,,44,,,,,,,,,,,,,,,,,,,,,,1,,203,23
+ java.io,66,1,225,,,,,,,,,22,,,,,,,,,,,,,,,44,,,,,,,,,,,,,,,,,,,,,,1,,202,23 |
added 2 commits
February 14, 2025 15:16
|
The new DCA run looks good. |
owen-mc
previously approved these changes
Feb 17, 2025
owen-mc
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a path injection sanitizer for the
childargument of ajava.io.Fileconstructor when that argument is normalized or checked for the absence of "..".Consideration
Note that sanitizing the second argument of the
Fileconstructor also sanitizes other uses of that variable after the constructor call (see theMISSINGcases in the tests). Let me know if there is some way to adjust the QL to avoid also sanitizing these other uses. I can sanitize theFileconstructor call instead of the second argument, but then the first argument needs to be checked for taint.Pull Request checklist
All query authors
Internal query authors only